This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Release: 3.1.0 #2938
Merged
Release: 3.1.0 #2938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2926) * make sure permission_callback is set correctly for all public routes * add permission_callback definition to all routes
… so it doesn't jump on mouseover (#2921) * add hover style to ensure consistent margin/padding for order summary * decrease specificity of panel__button hover/active etc styles
…2925) * fix typo in state property for idle status in checkout state reducer * remove arg causing failure in phpunit tests on travis
|
Size Change: +189 B (0%) Total Size: 1.64 MB
ℹ️ View Unchanged
|
This will notify rubik's slack channel when this workflow starts and finishes.
Testing NotesOverall, things tested really well. Style RegressionsNote I'm testing on the following:
The only thing in the below notes that is a regression from 2.7.1 is the interstitial edit view for the Reviews by Product and Reviews by Category block. That should probably be fixed before releasing this branch. HandPicker Products block
In the interstitial where products are picked, the chips are broken (note this also applies to Products by Category, Products by Tag, Products by Attribute, and Reviews by Category blocks):
Reviews by ProductThis is a regression from 2.7.1, in 2.7.1 it looks like this:
In this branch I see the below screenshot. Is this expected for the interstitial product selection view (note the horizontal grey line and the narrow off center radio selection container)? The same similar layout exists for the Reviews by Category block too.
Note, the same issue appears in WP 5.5 RC1
Product Search
The appearance of the search field varies between the editor and frontend: Editor: Frontend: |
|
Thanks for testing @nerrad!
This seems to be #2407, right?
Good catch! That's because the reviews blocks use a different folder structure and the
We might need to create an issue for this one (I can take care of it after the release). Part of the differences might be due to #2487, but probably there is something else causing style discrepancies. |
Remove Suspense compatibility fix once WP 5.2 is no longe...Remove Suspense compatibility fix once WP 5.2 is no longer supported. If Suspense is not available (WP 5.2), use a noop component instead. https://github.com/woocommerce/woocommerce-gutenberg-products-block/blob/a2e15e20fc023fbd9716cfda2467f89ce8a5eb30/assets/js/base/utils/render-frontend.js#L25-L34🚀 This comment was generated by the automations bot based on a
|
|
Merge PR in Core created: woocommerce/woocommerce#27177. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the release pull request for WooCommerce Blocks 3.1.
Communication
This release fixes an issue with the Product summary inner block in the All Products block that was not being rendered correctly.
Prepared Updates
The following documentation, blog posts, and changelog updates are prepared for the release:
Release announcement: in process
Developer Notes - N/A
Relevant developer documentation: N/A
Quality
Changes in this release are covered by Automated Tests.
This release has been tested on the following platforms:
This release affects public facing REST APIs.
This release impacts other extensions or backward compatibility.
Link to testing instructions for this release: Testing Instructions
The release has a negative performance impact on sites.
The release has positive performance impact on sites. If checked, please document these improvements here.
Notes on performance
New CSS webpack config
This release generates CSS files in a new way (see #2818 for more info). That resulted in a bigger CSS file for legacy builds. Non-legacy builds aren't affected (in fact, they got a small size decrease).